<html>
<head><meta charset="utf-8"><title>shellcheck · t-compiler/help · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/index.html">t-compiler/help</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/shellcheck.html">shellcheck</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="212172626"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/shellcheck/near/212172626" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/shellcheck.html#212172626">(Oct 03 2020 at 13:45)</a>:</h4>
<blockquote>
<p>Largely I just don't know that we get value out of this that outweighs the downsides.</p>
</blockquote>
<p>I wish you said this before I spent an hour on it :(</p>



<a name="212172858"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/shellcheck/near/212172858" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/shellcheck.html#212172858">(Oct 03 2020 at 13:46)</a>:</h4>
<p>I have not had the time to look over the patch in detail until now, I'm afraid.</p>



<a name="212173315"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/shellcheck/near/212173315" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/shellcheck.html#212173315">(Oct 03 2020 at 13:48)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/182449-t-compiler.2Fhelp/topic/.60x.2Epy.20check.60.20using.20stage.201.3F/near/212172858">said</a>:</p>
<blockquote>
<p>I have not had the time to look over the patch in detail until now, I'm afraid.</p>
</blockquote>
<p>assuming the try build succeeds, are you ok with me approving it? some things like using arrays instead of <code>x="$x --arg"</code> really do make it easier to read</p>



<a name="212173328"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/shellcheck/near/212173328" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/shellcheck.html#212173328">(Oct 03 2020 at 13:49)</a>:</h4>
<p>Yes, given it's the start of the cycle.</p>



<a name="212173343"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/shellcheck/near/212173343" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/shellcheck.html#212173343">(Oct 03 2020 at 13:49)</a>:</h4>
<p>I'm just saying that I will not / do not have the time to fix regressions etc this introduces, so we will likely just revert it wholesale if it does that and no one steps up quickly to fix them.</p>



<a name="212173392"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/shellcheck/near/212173392" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/shellcheck.html#212173392">(Oct 03 2020 at 13:50)</a>:</h4>
<p>ok, fair enough</p>



<a name="212173401"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/shellcheck/near/212173401" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/shellcheck.html#212173401">(Oct 03 2020 at 13:51)</a>:</h4>
<p>I'll try to get quick fixes in for any issues, I expect them to be reasonably easy to fix although not perhaps to figure out</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>